# Fix Authentication and CSP Issues - TODO

## Issues to Fix
1. ✅ Authentication required error in /researcher/connections.php
2. ✅ CSP violation blocking unpkg.com scripts
3. ✅ CSP violation blocking API connections (connect-src)
4. ✅ API 400 errors for contact-requests.php

## Implementation Steps

### Step 1: Fix CSP Headers in security.php ✅
- [x] Add unpkg.com to script-src directive
- [x] Add unpkg.com to style-src directive
- [x] Add explicit connect-src directive for API calls
- [x] Remove conflicting CSP from researcher-header.php meta tag

### Step 2: Fix Session/Authentication Issues ✅
- [x] Verify session handling in API
- [x] Ensure proper CORS headers for same-origin requests
- [x] Add better error logging

### Step 3: Update API Error Handling ✅
- [x] Improve error responses in contact-requests.php
- [x] Add proper HTTP status codes
- [x] Better session debugging
- [x] Handle preflight OPTIONS requests

### Step 4: Testing
- [ ] Test connections.php page loads without errors
- [ ] Test API calls work properly
- [ ] Verify no CSP violations in console
- [ ] Verify authentication works correctly

## Changes Made

### 1. includes/security.php
- Updated `setSecurityHeaders()` function to include:
  - Added `https://unpkg.com` to both `script-src` and `style-src` directives
  - Added explicit `connect-src 'self'` directive to allow same-origin API calls
  - Improved CSP formatting for better readability

### 2. templates/researcher-header.php
- Removed conflicting CSP meta tag that was overriding the header-based CSP
- Now relies solely on the CSP headers set by security.php

### 3. api/contact-requests.php
- Improved CORS headers for same-origin requests
- Changed from `Access-Control-Allow-Origin: *` to proper credentials handling
- Added `Access-Control-Allow-Credentials: true` header
- Added handling for OPTIONS preflight requests
- Enhanced error logging with session ID and authentication status
- Improved error responses with more descriptive messages
- Better HTTP status code handling (401 for auth errors, 400 for other errors)

## Next Steps
User should test the application to verify all issues are resolved.
